Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super admin session poisoning after switching roles via dropdown #4293

Closed
3 tasks
cielf opened this issue Apr 21, 2024 · 3 comments · Fixed by #4377
Closed
3 tasks

Super admin session poisoning after switching roles via dropdown #4293

cielf opened this issue Apr 21, 2024 · 3 comments · Fixed by #4377
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Apr 21, 2024

Summary

Fix problems when you are a superadmin and org user

Why

Improves support capability

Details

You should be able to switch back and forth between superadmin and org_admin.
Part 1: The "Switch To" functionality that we have for orgs/partners needs to be available for superadmins as well.

Part 2: "My Organization" should not show up when you are operating as a superadmin, and the "Administration" drop down that appears when you are a superadmin operating as an org_admin should also be removed.

This is ranked advanced because it requires high knowledge of how users and roles work in this system.

original ask

Aside from many 500s, there's an issue that seems to break my login session when I try to act as the bank admin for the r4g test bank in prod. Steps:

  1. login (takes me to super dashboard)
  2. click 'My Organization' (only way to go to prod test org…its dashboard now has embedded 500…i think that's new. Also, at this point, i can jump back to admin via Administration dropdown at top and then repeat this step num 2 to come back here…can do that indefinitely and it works.)
  3. click Switch to: Ruby For Good Test. Takes me to a 500 text page 500 Internal Server Error If you are the administrator of this website, then please read this web application's log file and/or the web server's log file to find out what went wrong. with url https://humanessentials.app/rfgtest/dashboard.

Image

if i try to go back, i go back to the super admin view. when i click My Organization, i get the same 500 text page mentioned above. can't get back to the bank until logging out + logging back in.

Criteria for completion

  • Can switch back and forth between superadmin and orgadmin properly as described
  • There is only one way to switch back and forth between superadmin and orgadmin
  • tests to support above
@jp524
Copy link
Contributor

jp524 commented May 5, 2024

I'd like to work on this but I won't be able to get started right away. If someone else would like to take this issue in the meantime, feel free!

@jp524
Copy link
Contributor

jp524 commented May 20, 2024

I'm ready to work on this :) Could you please assign me the issue @cielf?

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label May 20, 2024
@cielf
Copy link
Collaborator Author

cielf commented May 20, 2024

It is, apparently, yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants