Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of items in inventory adjustment should be alphabetical #4219

Closed
2 tasks
cielf opened this issue Mar 24, 2024 · 13 comments · May be fixed by #4380
Closed
2 tasks

Order of items in inventory adjustment should be alphabetical #4219

cielf opened this issue Mar 24, 2024 · 13 comments · May be fixed by #4380
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced stale

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 24, 2024

Summary

The order of items in the inventory adjustment drop downs is weird? It should be alphabetical by name

Why

Ease of finding items in the list

Details

This may only be showing up on a new storage location. To create a new storage location, sign in as org_admin1@example.com, go to Inventory | Storage Locations and select "New Storage Location".
After saving your new storage location, go to Inventory | Inventory Adjustments. Click on "New Adjustment" and select your new storage location in "From storage location". The items are not in alphabetical order. They should be.

Criteria for completion

  • behaviour as described above
  • tests to demonstrate the behavior
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Mar 24, 2024
@nikolaz90
Copy link
Contributor

Hello,
Happy to take this one if it's still going :)

@cielf
Copy link
Collaborator Author

cielf commented Mar 25, 2024

Hey @nikolaz90 -- We usually reserve things with the Good First Issue label for brand new contributors -- they are small enough that they are ideal for tackling when you are first setting up your environment.

There is another Difficulty - Beginner issue available -- #4218 -- take a look (someone has said they could work on it in a few days, but that it's ok if someone else jumps in). What do you think?

@nikolaz90
Copy link
Contributor

Oops, my mistake @cielf !
Sure! I'll have a look :)

@16dango
Copy link

16dango commented Mar 26, 2024

@cielf
I'm new to contribute here, I'd like to do this. Is it Okay?

@cielf
Copy link
Collaborator Author

cielf commented Mar 26, 2024

Welcome! You've got this one!

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Apr 26, 2024
@16dango
Copy link

16dango commented Apr 28, 2024

I'm still working on this issue

Copy link
Contributor

github-actions bot commented May 6, 2024

Automatically unassigned after 7 days of inactivity.

@16dango
Copy link

16dango commented May 7, 2024

@cielf I'm still working on this issue

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@iamronakgupta
Copy link

Can I take this up ?

@dorner
Copy link
Collaborator

dorner commented May 24, 2024

Go for it!

@cielf
Copy link
Collaborator Author

cielf commented May 26, 2024

Closing this -- it appears the items are in machine-alphabetical order. Which is consistent with the rest of the system -- I believe we should be doing a case insensitive alphatization but it should be coordinated with all the other things.

@cielf cielf closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants