-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove item generation #4206
remove item generation #4206
Conversation
d9124c4
to
4c21a9f
Compare
6159db3
to
6b6e90c
Compare
Yes, this looks great! I'd try to limit the unrelated changes because this is already a really beefy PR. |
This is just a really early draft. But what do you think is the best way to break it up? I was thinking:
I was also replacing some some validations and adding association tests with shoulda matchers, which is what I assume you mean by unrelated changes. It made sense to me to "spruce" up the specs and I would open a seperate PR for those changes. That said. How do you feel about replacing some of those validations with shoulda matchers? I know a lot of people are kind of against them. |
I was more referring to things like https://github.com/rubyforgood/human-essentials/pull/4206/files#diff-f20ad13724257719bda72f3a7df9e41664e7c5dd4c8ac8f20a08016c72a7ebb4L29 and https://github.com/rubyforgood/human-essentials/pull/4206/files#diff-9f295d05ef1f1d3fa56e894bd8858741bccb3bae309333f4ee47bd2de3aba8c2R120 . Honestly, I don't find a lot of value at all in the specs that just restate what the model has on it (things like |
I think the way you want to break it makes a lot of sense - let's make it 10 specs as a nice round number and so we don't have dozens of PRs 馃槃 |
651f6bf
to
5baf08a
Compare
411c77a
to
e60536d
Compare
7dcf7fa
to
1088d90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a file was checked in by accident?
1088d90
to
093fe39
Compare
4381c50
to
204c6b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last merge mixup I think! Btw can you please ensure you are not force pushing the branch? I.e. when you merge master please ensure you are using merge and not rebase.
Finally done! Kudos on a very long and tedious project - I am super happy with the changes! 馃帀 |
@elasticspoon: Your PR |
Fixes #4199
Removes
seed_items: false
from org creationRemoves
skip_seed: true
from all specsRemoves all code that used the above behaviors.
Tests no longer rely on preseeded data! 馃コ
Base Changes to enable removal of seeding:
Additional PRs: