Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag that is the type of request. #4175

Open
5 tasks
cielf opened this issue Mar 10, 2024 · 14 comments · May be fixed by #4271
Open
5 tasks

Add a flag that is the type of request. #4175

cielf opened this issue Mar 10, 2024 · 14 comments · May be fixed by #4271

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 10, 2024

Summary

Add a request type flag that will be visible to the banks

Why

The banks don't know which request types their partners are using. Knowing will help them supporting their partners

Details

Add a flag to request that will be set according to whether the request is a quantity request, a by-individuals request or a child-based request. Show this to the bank on their request view, and in the request export.

This would enable the banks to see, after a couple of cycles, whether any of their partners are using each request type, and be able to simplify the options available to their partners based on that information.

Criteria for completion

  • addition of flag to request model
  • setting the flag depending on the kind of request
  • displaying the flag on the bank's view of the request
  • displaying the flag in the request export.
  • tests to support the above functionality
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Mar 10, 2024
@nathangthomas
Copy link

@cielf I can take this ticket.

@cielf
Copy link
Collaborator Author

cielf commented Mar 15, 2024

Go for it!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Mar 15, 2024
@nathangthomas
Copy link

nathangthomas commented Mar 15, 2024

Would it be beneficial for there to be a default request type? If so which one?

  1. quantity
  2. by-individuals
  3. child-based

EDIT
Actually... After digging into this a bit more it doesn't seem like there will be a need for a default request as type will be automatically set each time a new request is made.

@cielf
Copy link
Collaborator Author

cielf commented Mar 16, 2024

That's right -- the type will be known before the request is created.

@nathangthomas
Copy link

nathangthomas commented Mar 19, 2024

@cielf are there any specific colors you would like each flag to be? I have included some screenshots of the request index and show pages as well as the export.

@nathangthomas
Copy link

Screenshot 2024-03-19 at 11 45 29 AM

@nathangthomas
Copy link

Screenshot 2024-03-19 at 11 51 34 AM

@nathangthomas
Copy link

Screenshot 2024-03-19 at 12 34 22 PM

@cielf
Copy link
Collaborator Author

cielf commented Mar 19, 2024

Lets just have them all be normal text. They are just informational, and otherwise the users might think they are buttons.

I would actually just call them quantity, individual and child as well (should have noticed that earlier).

@nathangthomas nathangthomas linked a pull request Apr 12, 2024 that will close this issue
Copy link
Contributor

github-actions bot commented May 3, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf
Copy link
Collaborator Author

cielf commented May 18, 2024

This is in the final throes of review.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants