Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] On Donation, drop down changes to show item number rather than description on edit error. It shouldn't. #4172

Open
2 tasks
cielf opened this issue Mar 10, 2024 · 4 comments

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 10, 2024

Summary

If you have a validation error on saving the donation, the dropdownfor the item changes to a number rather than the item name. It should still show the item name.

Details

Recreation

I've been able to recreate this by producing an error where you can't reduce the quantity because it would take the inventory negative.
To do that:
Enter a donation with a large number of some item.
Next, enter a distribution that reduces the inventory to less than the number of items in the donation
Then, edit the donation. Reduce the number of items in the donation to 1. (this doesn't have to realistic, we're just trying to produce the error.)
Save. You should get an error, and a screen similar to this (the numbers will obviously be different)

Screenshot 2024-02-25 at 8 40 16 AM

Instead, you should be seeing the item name where it shows "1" in the above screenshot.

Criteria for completion

  • The item name dropdown is still there after the error.
  • tests to demonstrate.
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Mar 10, 2024
@ZahBenjamin
Copy link

Hey there @cielf I would love to try and solve this

@dorner
Copy link
Collaborator

dorner commented Mar 11, 2024

Give it a go!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Mar 11, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants