Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslashes removed in title e.g. C:\dev\alex\test.json -> C:devalex.json #525

Open
alexsuter opened this issue Feb 6, 2024 · 1 comment
Labels

Comments

@alexsuter
Copy link

Step -1: Before filling an issue check out troubleshooting section

Step 0: Describe your environment

  • OS: everywhere
  • diff2html version: latest
  • Using diff2html directly or using diff2html-ui helper: diff2html
  • Extra flags: not relevant

Step 1: Describe the problem:

Steps to reproduce:

  1. Use a patch with windows paths

diff example:

diff --git a/sample.js b/sample.js
index 0000001..0ddf2ba
--- C:\dev\alex.js
+++ b/sample.js
@@ -1 +1 @@
-console.log("Hello World!")
+console.log("Hello from Diff2Html!")

Observed Results:

  • Backslashes removed in title e.g. C:\dev\alex\test.json -> C:devalex.json

Expected Results:

  • Backslashes won't be removed

Relevant Code:

image

@rtfpessoa rtfpessoa added the bug label Apr 19, 2024
@rtfpessoa
Copy link
Owner

Cannot replicate the issue on my side.
Also that diff seems manipulated since the header file has a different name from the one in the +++ tag.
Also the +++ tag misses the a/ prefix.

Maybe something specific to windows? I don't have a way to test atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants