Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight.js themes don't work correctly #191

Open
tomastrajan opened this issue Feb 2, 2019 · 4 comments
Open

Highlight.js themes don't work correctly #191

tomastrajan opened this issue Feb 2, 2019 · 4 comments

Comments

@tomastrajan
Copy link

I have been trying to replace github.min.css theme with other highlight.js themes but without success. The text color is taken but the whole result is a combination of some default styles and theme which looks weird?
bu

@tomastrajan tomastrajan changed the title Themes doesn't work Themes don't work Feb 2, 2019
@tomastrajan
Copy link
Author

Also, my css and scripts seem to be ok hmm...
bug2

@rtfpessoa
Copy link
Owner

@tomastrajan sorry for the delay getting back to you but I did not get time to actually test it.
Today I did a quick check and seems like a basic styling issue.

If you change the order of the styles and import the atom one last it will be a bit better but still not work.
When I did this I never intended to support multiple styles and for that reason it does not work by default.

If you are interested and taking a look and understanding what needs to be done to fix this I would gladly accept a contribution.

@tomastrajan
Copy link
Author

@rtfpessoa thank you for getting back to me, yeah I might have a look but cant promise anything ;)

@tomastrajan
Copy link
Author

@rtfpessoa btw thanks for the killer lib, it's very useful!

@rtfpessoa rtfpessoa changed the title Themes don't work Highlight.js themes don't work correctly Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants