Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR should not be merged as it's just a starting point for testing. I don't currently have a working Windows dev setup for RStudio (my VM got borked a few weeks back) so hope that someone who does can validate that these changes are correct and complete).
RTools is doing a minor update to v3.5 as part of the upcoming R 3.5 release. According to Jeroen:
RStudio needs to have knowledge of various versions of Rtools for 2 reasons:
When we scan the registry for installed versions of Rtools we need to know which versions of R they are compatible with as well as what directories to add to the PATH as well as what directories should be made available to libclang for code completion.
When we prompt for the installation of Rtools we need to know which version to suggest based on the current version of R as well as it's URL.
As you can see from this change based on Jeroen's description of Rtools 3.5 being just an update to embedded tools we basically treat Rtools 3.4 and 3.5 exactly the same. We should test to ensure that this is in fact the case.
Note that another part of this change is asserting that Rtools 3.4 will work for versions of R >= 3.5. Current installed versions of the IDE contain the assertion that Rtools 3.4 only works up to R 3.4, which means that anyone running R 3.5 pre-releases (or the final release later this month) will not be able to use Rtools with RStudio! This implies that we need this change to be backported to the public release as soon as we've validated it.
So the remaining work here is to validate that this change:
Successfully identifies and uses Rtools 3.5 when it's available (this applies to both package building and use of libclang autocomplete and diagnostics)
Allows the use of Rtools 3.4 for R version 3.5 (to test this you need to make sure that Rtools 3.5 is NOT installed)
Prompts for and successfully installs Rtools 3.5 when no version of Rtools is currently available.