F1 doesn't show help and throws error on dataset autocomplete

[ronblum]

System details

RStudio Edition : Server and Desktop
RStudio Version : 1.1.383, 1.1.423, 1.1.442
OS Version      : Mac, Windows, and Linux variants
R Version       : 3.4.3

Steps to reproduce the problem

1. Type iris at the console, and wait for help topic autocompletions to appear.
2. Select an autocompletion with the arrow keys, e.g. iris
3. Press F1 to see help on the dataset.

Describe the problem in detail

No help appears, and the following error message is displayed at the console:

Error in find.package(if (is.null(package)) loadedNamespaces() else package, :
there is no package called ‘package:datasets’

(Clicked F1 multiple times for screenshot to show error + autocompletion)

Describe the behavior you expected

Help on the dataset, iris, should appear in the Help pane, with no error message.

Cf. #2261 and #2348.

[jmcphers]

@kevinushey Does it look like we need to extend the fix in #2261 in some way, or is this a different bug?

[kevinushey]

I think this may be a different issue -- I'll take a look.

[kevinushey]

I'm surprised to find out that this actually reproduces back in RStudio v1.0. I guess users don't press F1 when the help menu is showing very often :-)

[kevinushey]

Should be fixed with 1e5e7dc. It looks like we only trimmed the package: prefix in certain code paths; we should be doing that universally.

[jmcphers]

Okay, thanks for jumping on that! Given that it is not a regression in 1.1 and hasn't ever been reported before to the best of my knowledge, I don't intend to backport it (let me know if you disagree).

[jmcphers]

Closing since we appear to have fixed this a couple of years ago.