Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempting to publish an unsaved document warns and opens file dialog at same time #1937

Closed
kevinushey opened this issue Jan 10, 2018 · 3 comments
Closed

attempting to publish an unsaved document warns and opens file dialog at same time #1937

kevinushey opened this issue Jan 10, 2018 · 3 comments
Labels
bug reproducible
Milestone
v1.1-patch

Comments

@kevinushey
Copy link
Contributor

kevinushey commented Jan 10, 2018 •
edited

This was with RStudio v1.1.412 on macOS Desktop.

small

We probably want to show just one or the other.
@kevinushey kevinushey changed the title attempting to publish an unsaved document warns and opens system dialog at same time attempting to publish an unsaved document warns and opens file dialog at same time Jan 10, 2018
@jmcphers jmcphers added this to the v1.1-patch milestone Jan 10, 2018
@jmcphers
Copy link
Member

Patch candidate since probably downstream from #1821.

jmcphers added a commit that referenced this issue Jan 10, 2018
@jmcphers
don't attempt to save untitled docs when publishing; fixes #1937
7d420b4
jmcphers added a commit that referenced this issue Jan 10, 2018
@jmcphers
don't attempt to save untitled docs when publishing; fixes #1937
2484a69
@jmcphers
Copy link
Member

Backported to 1.1 in 2484a69.

@ronblum
Copy link
Contributor

ronblum commented Jan 16, 2018

Confirmed in RStudio MacOS Desktop 1.1.414.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug reproducible
Projects
None yet
Milestone
v1.1-patch
Development

No branches or pull requests
3 participants
@jmcphers @kevinushey @ronblum