Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too easy to publish unsaved content #1821

Closed
jmcphers opened this issue Dec 7, 2017 · 3 comments
Closed

Too easy to publish unsaved content #1821

jmcphers opened this issue Dec 7, 2017 · 3 comments
Assignees
@jmcphers
Milestone
v1.1-patch

Comments

@jmcphers
Copy link
Member

jmcphers commented Dec 7, 2017

Repro:

  1. Create an R Markdown document.
  2. Make some changes to the document, but do not save them.
  3. Click "Publish".

The document is not saved, and the saved version is published. We should have a warning and/or autosave here.

(originally via @scottmjackson)
@jmcphers jmcphers self-assigned this Dec 7, 2017
@jmcphers jmcphers added this to the v1.1-patch milestone Dec 8, 2017
@jmcphers
Copy link
Member Author

jmcphers commented Dec 8, 2017

Might as well backport this to patch, as it's very low-risk and has been brought up a couple of times.

jmcphers added a commit that referenced this issue Dec 11, 2017
@jmcphers
save documents before publishing them; fixes #1821
7c7cb26
@jmcphers
Copy link
Member Author

Backported to 1.1 in 7c7cb26.

@ronblum
Copy link
Contributor

ronblum commented Dec 15, 2017

Verified in 1.1.399.

@jmcphers jmcphers mentioned this issue Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcphers jmcphers

Labels
None yet
Projects
None yet
Milestone
v1.1-patch
Development

No branches or pull requests
2 participants
@jmcphers @ronblum