Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background highlighter triggered after reindenting selection #1643

Closed
kevinushey opened this issue Oct 21, 2017 · 4 comments
Closed

Background highlighter triggered after reindenting selection #1643

kevinushey opened this issue Oct 21, 2017 · 4 comments
Assignees
@kevinushey
Labels
bug
Milestone
v1.1-patch

Comments

@kevinushey
Copy link
Contributor

Given the following code in an R document:

if (0) {
  
} else {
  
}

Highlighting the whole selection with Cmd + A and re-indenting with Cmd + I leaves the last line highlighted:

screen shot 2017-10-20 at 7 11 28 pm
@kevinushey kevinushey added the bug label Oct 21, 2017
@kevinushey kevinushey added this to the v1.1-patch milestone Oct 21, 2017
@kevinushey kevinushey self-assigned this Oct 21, 2017
kevinushey added a commit that referenced this issue Oct 21, 2017
@kevinushey
only activate background highlighter when needed (#1643)
7d75260
kevinushey added a commit that referenced this issue Dec 6, 2017
@kevinushey
only activate background highlighter when needed (#1643)
30fd018
@kevinushey
Copy link
Contributor Author

kevinushey commented Dec 6, 2017 •
edited

Cherry-picked to v1.1-patch: 30fd018

@ronblum
Copy link
Contributor

ronblum commented Dec 15, 2017

Verified in 1.1.399.

@shearerpmm
Copy link

Thank you! I was the issue submitter. Glad I can finally migrate to v1.1 and use all the new features.

@ronblum
Copy link
Contributor

ronblum commented Mar 13, 2018

@shearerp You're welcome—I hope you find the new features helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinushey kevinushey

Labels
bug
Projects
None yet
Milestone
v1.1-patch
Development

No branches or pull requests
3 participants
@kevinushey @shearerpmm @ronblum