Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider DEPLOY_MSG #53

Open
jennybc opened this issue Oct 8, 2019 · 1 comment
Open

Reconsider DEPLOY_MSG #53

jennybc opened this issue Oct 8, 2019 · 1 comment

Comments

@jennybc
Copy link
Collaborator

jennybc commented Oct 8, 2019

My approach to making the DEPLOY_MSG in .travis.yml is not robust to quotes inside the commit message.

https://github.com/rstudio-education/stat545/blob/master/.travis.yml#L19

If the truncation to first n characters happens to catch, say, an opening " but not the closing, it can cause problems:

Happened with 46a81ad

Notice the cryptic error in the deploy stage:

https://travis-ci.org/rstudio-education/stat545/builds/589671690#L900-L903

Deploying application
sh: 1: Syntax error: Unterminated quoted string
Script failed with status 2

Caused by unfortunate truncating of this commit message:

Link to the ellipsis package and "Data, dots, details"
@jennybc
Copy link
Collaborator Author

jennybc commented Oct 8, 2019

Suggestion from @jimhester: Try git log --pretty='%h %s' HEAD | cut -c-60. If you never use bash string interpolation you don't need to worry about quoting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant