Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to retrieve status and or finished_at in example_finished listener. #2290

Closed
RodneyU215 opened this issue Jul 13, 2016 · 3 comments
Closed

Comments

@RodneyU215
Copy link

RodneyU215 commented Jul 13, 2016

Problem: notification.example.execution_result.finished_at and notification.example.execution_result.status return nil in the example_finished method of my custom listener.

Failing Spec:
A reproducible example can be found here: https://github.com/Rodney-QAGeek/rspec_example
I hope you don't mind this format, but this issue was difficult for me to reproduce with the Unit tests in rspec-core. I'd love feedback on how I could have gotten this to reproduce with the rspec unit tests in the project.

@myronmarston FYI, this is the bug I brought up in #2289

@myronmarston
Copy link
Member

I hope you don't mind this format, but this issue was difficult for me to reproduce with the Unit tests in rspec-core

What you've done is fantastic :).

@myronmarston
Copy link
Member

I've got a fix in #2291.

I'd love feedback on how I could have gotten this to reproduce with the rspec unit tests in the project.

You can check out how I did it, if that helps.

@myronmarston
Copy link
Member

The fix is in master and 3-5-maintenance and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants