Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a working rsocket-kotlin and Android example #164

Open
yschimke opened this issue Jun 15, 2021 · 9 comments
Open

Provide a working rsocket-kotlin and Android example #164

yschimke opened this issue Jun 15, 2021 · 9 comments

Comments

@yschimke
Copy link
Member

Out of https://stackoverflow.com/questions/67837839/is-it-possible-to-use-rsocket-in-android-with-kotlin

We should provide a working example android test, similar to https://github.com/square/okhttp/tree/master/android-test

@clayly
Copy link

clayly commented Jun 30, 2021

Can i help somehow with such example? Is it suitable for Android in any way?

@yschimke
Copy link
Member Author

yschimke commented Jul 1, 2021

What are you thinking? Add a test that runs in CI as described above?

Alternatively a relatively clean sample that hit demo.rsocket.io would be a good starting point.

@clayly
Copy link

clayly commented Jul 10, 2021

What are you thinking? Add a test that runs in CI as described above?

Alternatively a relatively clean sample that hit demo.rsocket.io would be a good starting point.

I am working on it, diving into the project. Is there something special about contributing what i should know?

@yschimke
Copy link
Member Author

yschimke commented Jul 11, 2021

No, put up something for discussion and it should flush out any concerns. Thanks!

If there is anything we are missing we should clarify it in the docs.

@LittleTrickster
Copy link

I did create a demo https://github.com/LittleTrickster/AndroidRSocketDemo (it's a little bloated for a demo) that works both as a server and a client but there is still #148 issue that crashes the whole app when the client loses connection to the server.
Used unsafe workaround with Thread.setDefaultUncaughtExceptionHandler to prevent the crash for now.

@clayly
Copy link

clayly commented Jul 21, 2021

I did create a demo https://github.com/LittleTrickster/AndroidRSocketDemo (it's a little bloated for a demo) that works both as a server and a client but there is still #148 issue that crashes the whole app when the client loses connection to the server.
Used unsafe workaround with Thread.setDefaultUncaughtExceptionHandler to prevent the crash for now.

Have you tried to make it work with okHttp?

@LittleTrickster
Copy link

I did create a demo https://github.com/LittleTrickster/AndroidRSocketDemo (it's a little bloated for a demo) that works both as a server and a client but there is still #148 issue that crashes the whole app when the client loses connection to the server.
Used unsafe workaround with Thread.setDefaultUncaughtExceptionHandler to prevent the crash for now.

Have you tried to make it work with okHttp?

Yeah it works just add android:usesCleartextTraffic="true" to manifest.

@androiddevcoding
Copy link

@LittleTrickster Is the sample project up to date?

@LittleTrickster
Copy link

@nailshakurov It's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants