Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Uint8Array as replacement for Buffer #273

Open
viglucci opened this issue Feb 19, 2024 · 0 comments
Open

Investigate Uint8Array as replacement for Buffer #273

viglucci opened this issue Feb 19, 2024 · 0 comments
Assignees
@viglucci
Labels
1.0 Pullrequests & issues related to the Typescript rewrite and 1.0 release enhancement Suggests, requests, or implements a feature or enhancement

Comments

@viglucci
Copy link
Member

viglucci commented Feb 19, 2024 •
edited

We should look into using Uint8Array as an alternative to Buffer since from what I am reading it is supported in both Browser & Node runtimes.

Motivation

Simplify usage of rsocket-js in browser environments.

Desired solution

Replace Buffer usage with Uint8Array.

Considered alternatives

Continue using Buffer and provide stronger guidance that Browser use-cases will require polyfill.

Additional context
@viglucci viglucci self-assigned this Feb 19, 2024
@viglucci viglucci added enhancement Suggests, requests, or implements a feature or enhancement 1.0 Pullrequests & issues related to the Typescript rewrite and 1.0 release labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viglucci viglucci

Labels
1.0 Pullrequests & issues related to the Typescript rewrite and 1.0 release enhancement Suggests, requests, or implements a feature or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viglucci