Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep an eye out for slowness from std vector copying #44

Open
rsmith54 opened this issue Jan 27, 2016 · 0 comments
Open

Keep an eye out for slowness from std vector copying #44

rsmith54 opened this issue Jan 27, 2016 · 0 comments
Assignees
Labels

Comments

@rsmith54
Copy link
Owner

In things like the RegionVarsCalculator, we are copying the vectors over into the map after the push_backs.

This is definitely slower than allocating the vectors on the heap, and also slower than assigning the map with an empty vector and push_back'ing into a reference to the vector from the map, but I think it's better to keep it since it's a lot simpler as is. IF we have problems with speed at some point we can reconsider this.

@rsmith54 rsmith54 self-assigned this Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants