Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper CBK finding #103

Open
rsmith54 opened this issue May 3, 2016 · 1 comment
Open

proper CBK finding #103

rsmith54 opened this issue May 3, 2016 · 1 comment

Comments

@rsmith54
Copy link
Owner

rsmith54 commented May 3, 2016

I think this is what we actually want to do to figure out the right CBK object :

martin tripiana tripiana@cern.ch
11:44 AM (1 hour ago)

to atlas-phys-sus.
Dear all,

 we wanted to bring your attention to an issue observed by Ximo & Othmane (&others) with the way we (used to) access the CBK metadata in our SUSY derivations.

Long story short, the usual prescription of taking the lowest-n cycle among the complete
cbks available doesn't not longer apply in the new derivations. Or so it seems from some
few samples we looked at.

As you see below, the old rcp can give odd results now, as we have the info for more
primitive steps in the prod chain and of all the steps in the relevant train.

We put a quick fix example in the SUSYToolsTester code in the trunk just before which gives the expected results for now.

https://svnweb.cern.ch/trac/atlasoff/browser/PhysicsAnalysis/SUSYPhys/SUSYTools/trunk/util/SUSYToolsTester.cxx#L130

Please take note of this and report back if you find a problem with the new approach.

Best regards,
M/C


Issue Example (before fix!):

NEW 20.7
mc15_13TeV.361070.Sherpa_CT10_llvvjj_ss_EW6.merge.DAOD_SUSY2.e3836_s2608_s2183_r7725_r7676_p2613_tid08198517_00/DAOD_SUSY2.08198517._000001.pool.root.1
AllExecutedEvents : desc = N/A : inputStream = StreamDAOD_SUSY2 : cycle = 6 : allEvents = 4348
AllExecutedEvents : desc = N/A : inputStream = StreamAOD : cycle = 5 : allEvents = 10000
SUSY3KernelAug : desc = N/A : inputStream = StreamAOD : cycle = 5 : allEvents = 10000
SUSY3KernelSkim : desc = N/A : inputStream = StreamAOD : cycle = 5 : allEvents = 5842
SUSY2KernelAug : desc = N/A : inputStream = StreamAOD : cycle = 5 : allEvents = 10000
SUSY2KernelSkim : desc = N/A : inputStream = StreamAOD : cycle = 5 : allEvents = 4348
SUSY5KernelSkim : desc = N/A : inputStream = StreamAOD : cycle = 5 : allEvents = 8341
SUSY5KernelAug : desc = N/A : inputStream = StreamAOD : cycle = 5 : allEvents = 8341
AllExecutedEvents : desc = N/A : inputStream = StreamAOD : cycle = 4 : allEvents = 10000
AllExecutedEvents : desc = N/A : inputStream = StreamAOD : cycle = 3 : allEvents = 8000
AllExecutedEvents : desc = N/A : inputStream = StreamESD : cycle = 2 : allEvents = 8000
AllExecutedEvents : desc = N/A : inputStream = StreamRDO : cycle = 1 : allEvents = 15912
AllExecutedEvents : desc = N/A : inputStream = StreamRDO : cycle = 0 : allEvents = 31736
SUSYToolsTester INFO CutBookkeepers Accepted 31736 SumWei 31942.399574 sumWei2 32593.949977 (WRONG!)

OLD 20.1
SUSYToolsTester INFO Opening file: /nfs/atlas-data07/tripiana/xAOD/CBKtest/mc15_13TeV.361070.Sherpa_CT10_llvvjj_ss_EW6.merge.DAOD_SUSY2.e3836_s2608_s2183_r7267_r6282_p2499_tid08215078_00/DAOD_SUSY2.08215078._000001.pool.root.1

SUSYToolsTester INFO Number of events in the file: 4669
AllExecutedEvents : desc = N/A : inputStream = StreamDAOD_SUSY2 : cycle = 2 : allEvents = 4669
AllExecutedEvents : desc = N/A : inputStream = StreamAOD : cycle = 1 : allEvents = 10000
SUSY2KernelAug : desc = N/A : inputStream = StreamAOD : cycle = 1 : allEvents = 10000
SUSY2KernelSkim : desc = N/A : inputStream = StreamAOD : cycle = 1 : allEvents = 4669
AllExecutedEvents : desc = N/A : inputStream = StreamAOD : cycle = 0 : allEvents = 10000
SUSYToolsTester INFO CutBookkeepers Accepted 10000 SumWei 10080.925944 sumWei2 10388.937223

@rsmith54
Copy link
Owner Author

Okay, I think we are doing this right, since it's basically done by xAODAnaHelpers. I just skimmed their logic and I think it does the same as the SUSYToolsTester, but it would be nice to have someone look at it quickly if they get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant