Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleHandler failure to find files doesn't offer any info #101

Open
rsmith54 opened this issue Apr 20, 2016 · 2 comments
Open

SampleHandler failure to find files doesn't offer any info #101

rsmith54 opened this issue Apr 20, 2016 · 2 comments
Assignees

Comments

@rsmith54
Copy link
Owner

@mattleblanc 's issue is what happens when the SampleHandler object is empty. This is actually quite annoying and should have some higher verbosity (probably not by default since SampleHandler spits out a lot of stuff with sh.printContent() ).

I made a few quick changes to look at this, but probably this is just some annoying failure in fillSampleHandler (maybe SampleHandler has changed?) .

This goes along with whatever was going on with FAX yesterday, but that's not our fault .

@rsmith54 rsmith54 self-assigned this Apr 20, 2016
@lawrenceleejr
Copy link
Collaborator

We could add a check in the common python or something that checks that the
final sample handler object isn't empty.

On Wed, Apr 20, 2016 at 10:41 AM Russell Smith notifications@github.com
wrote:

@mattleblanc https://github.com/mattleblanc 's issue is what happens
when the SampleHandler object is empty. This is actually quite annoying and
should have some higher verbosity (probably not by default since
SampleHandler spits out a lot of stuff with sh.printContent() ).

I made a few quick changes to look at this, but probably this is just some
annoying failure in fillSampleHandler (maybe SampleHandler has changed?) .

This goes along with whatever was going on with FAX yesterday, but that's
not our fault .


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#101

@rsmith54
Copy link
Owner Author

Yeah, I have that coded right now. I guess the thing is maybe we should
update the SH scanning to be not as dumb as it is by default with the newer
ScanDir vs scanDir.

On Wed, Apr 20, 2016 at 11:01 AM, Lawrence Lee notifications@github.com
wrote:

We could add a check in the common python or something that checks that the
final sample handler object isn't empty.

On Wed, Apr 20, 2016 at 10:41 AM Russell Smith notifications@github.com
wrote:

@mattleblanc https://github.com/mattleblanc 's issue is what happens
when the SampleHandler object is empty. This is actually quite annoying
and
should have some higher verbosity (probably not by default since
SampleHandler spits out a lot of stuff with sh.printContent() ).

I made a few quick changes to look at this, but probably this is just
some
annoying failure in fillSampleHandler (maybe SampleHandler has changed?)
.

This goes along with whatever was going on with FAX yesterday, but that's
not our fault .


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#101


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#101 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants