Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement error rules from eslint/ECMAScript 6 #53

Open
5 of 8 tasks
RDambrosio016 opened this issue Oct 17, 2020 · 0 comments
Open
5 of 8 tasks

Implement error rules from eslint/ECMAScript 6 #53

RDambrosio016 opened this issue Oct 17, 2020 · 0 comments
Labels
E-easy Fixing/implementing this issue is easy and usually fit for newcomers T-Runner This issue primary relates to the lint runner, rslint_core

Comments

@RDambrosio016
Copy link
Collaborator

RDambrosio016 commented Oct 17, 2020 •
edited by Stupremee

RSLint does not distinguish between ecma versions (because caring about standard versions does not matter), therefore we should fit some of eslint's ES6 rules into the errors group, those which actually cause errors.
Ive compiled a list of the rules which can be implemented into errors currently:

  • constructor-super
  • no-confusing-arrow
  • no-dupe-class-members
  • no-duplicate-imports
  • no-new-symbol
  • no-this-before-super

Rules im not sure about including

  • no-class-assign (i think this should be included since its a potential error/mistake)
  • require-yield (maybe this one too since its most likely a mistake and a potential error)

If you are looking for things to contribute to, this is a great list!
If you have any other rules i missed or have opinions on the rules im not sure about feel free to mention them 👍
@RDambrosio016 RDambrosio016 added E-easy Fixing/implementing this issue is easy and usually fit for newcomers T-Runner This issue primary relates to the lint runner, rslint_core labels Oct 17, 2020
@yamadayuki yamadayuki mentioned this issue Oct 20, 2020
Merged
@1011X 1011X mentioned this issue Feb 22, 2021
Merged
thecp added a commit to thecp/rslint that referenced this issue Jun 11, 2021
@thecp
Feat: Implement no-duplicate-imports error rule
3184c0f 
refs rslint#53
thecp added a commit to thecp/rslint that referenced this issue Jun 11, 2021
@thecp
Feat: Implement no-duplicate-imports error rule
d65b81f 
refs rslint#53
thecp added a commit to thecp/rslint that referenced this issue Jun 11, 2021
@thecp
Feat: Implement no-duplicate-imports error rule
587dd0a 
refs rslint#53
@thecp thecp mentioned this issue Jun 11, 2021
Merged
thecp added a commit to thecp/rslint that referenced this issue Jun 14, 2021
@thecp
Feat: Implement no-duplicate-imports error rule
e3526c2 
refs rslint#53
Stupremee pushed a commit that referenced this issue Jun 15, 2021
@thecp
Feat: Implement no-duplicate-imports error rule (#107)
00c4661 
* Feat: Implement no-duplicate-imports error rule

refs #53

* Chore: Disable docgen for rslint-lsp

Adding the `doc = false` flag for bin as docgen fails on Rust nightly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Fixing/implementing this issue is easy and usually fit for newcomers T-Runner This issue primary relates to the lint runner, rslint_core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RDambrosio016