Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX support #140

Open
Vannevelj opened this issue Mar 24, 2022 · 4 comments
Open

JSX support #140

Vannevelj opened this issue Mar 24, 2022 · 4 comments

Comments

@Vannevelj
Copy link

First of all, thank you for this great library! It's been a delight to work with, both for its speed as well as the easy-to-use API it exposes.

I'm aware that a point of difference with swc is JSX support -- do you have any intention to add JSX parsing?

For context, I've written a small tool building on rslint to convert Javascript to Typescript-compatible code: https://github.com/Vannevelj/type-rs
Running it on a test repo, I'm seeing that JSX issues account for a large number of the resulting errors, easily >50%.

@Stupremee
Copy link
Member

It's definitely a planned feature but I myself do not have the capacity to work on this project enough to implement it.

Luckily, the guys at rome took the rslint parser code to integrate it into their tool. So they basically have a full time team working on the parser and even JSX Support. It will take a few weeks or probably months for a first more-or-less stable version of their parser, but then I will migrate rslint using their rslint_parser version.

@Vannevelj
Copy link
Author

Oh wow, the timing is great here. Looks like they integrated rslint only yesterday and they've already started to add JSX support. Thanks, I'm happy to wait for that and looking forward to the result!

@cdimitroulas
Copy link

Looks like the JSX parsing support issue was closed in the rome project. Does that mean that it would be possible to take their parser implementation and port it over to rslint? :D

@Geocld
Copy link

Geocld commented Oct 25, 2023

To support JSX, I think it is possible to replace rslint_parser to biome_js_parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants