Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete keys works wrong #190

Open
ilanolkies opened this issue Apr 25, 2022 · 2 comments
Open

Delete keys works wrong #190

ilanolkies opened this issue Apr 25, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@ilanolkies
Copy link
Contributor

Now, when we click on 'delete master key', we need to reset the app and even the PIN is not deleted. We should implement deleteKeys in such way that it

  • deletes the mnemonic
  • deletes the PIN
  • updates the state properly to prevent need of reloading the app
@ilanolkies ilanolkies added the bug Something isn't working label Apr 25, 2022
@ilanolkies ilanolkies added this to the v1.0.0 milestone Apr 25, 2022
@jessgusclark
Copy link
Member

It should delete all of the RN Storage including the items above and the RNS domains associated with it.

@jessgusclark
Copy link
Member

One more thing I noticed, two screens currently have access to the deleteKeys function. I think only one of them actually needs it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants