Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language localisation #6

Open
victorsndvg opened this issue Nov 12, 2019 · 5 comments
Open

Language localisation #6

victorsndvg opened this issue Nov 12, 2019 · 5 comments

Comments

@victorsndvg
Copy link

Nice initiative!

it could be great to be able to translate it to other languages. I could help with spanish :)

@vsoch
Copy link
Collaborator

vsoch commented Nov 12, 2019

This is a great idea! And hey long time no see, good to see you!!

There are two ways (I can think of) to go about this -

  • use separate files for each language, at the risk of them going out of sync
  • put sections for languages below each term in the same file

The second approach is likely better so files don't get forgotten or go out of sync, although it risks having a really huge file if it gets too big. What are your thoughts? How is it done in other places? If we do choose to do separate files, there could be some check that (minimally) a term in an "other language" file is present in english. How would we keep the files / definitions in sync?

@victorsndvg
Copy link
Author

Good to see you too :)

Honestly, I don't have any experience on this ...

I think the first approach is better for a growing project, but if it's not going to be so big the second approach is ok for me too.

About synchronization, I think that English can be the default language, If other language is not synchronized then the default language should be shown for a particular term of the glossary (maybe with a message telling "This term was not yet translated to $LANGUAGE, please help us by opening an issue here ...")

What do you think?

@vsoch
Copy link
Collaborator

vsoch commented Nov 13, 2019

I love it! And I agree, we should develop in anticipation of growing size.

If you want to add a file to _data, perhaps terms_<language>.yml and start with a copy paste of the file (and then writing the definitions) I can then work on the interface to make it easy to toggle between.

@victorsndvg
Copy link
Author

Ok, perfect.

I will contribute soon with spanish (es-ES) and galician (gl).

We can use codes from http://www.lingoes.net/en/translator/langcode.htm to identify each language, e.g. terms_es-ES.yml. Do you agree?

@vsoch
Copy link
Collaborator

vsoch commented Nov 13, 2019

Yes, and let's add a link to that in the README under some section for "How to add a Language"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants