Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition out complex variable tests on mips64el #1059

Open
eddelbuettel opened this issue Aug 26, 2023 · 2 comments
Open

Condition out complex variable tests on mips64el #1059

eddelbuettel opened this issue Aug 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@eddelbuettel
Copy link

Is your feature request related to a problem? Please describe.

The platform Debian describes as 'mips64el', ie little endian mips64, has been seen failing its units tests for complex variables.

Describe the solution you'd like

A patch has been added to the Debian package I could PR here as well, it uses

@pytest.mark.skipif(platform.machine() == 'mips64' and sys.byteorder == 'little',
                    reason="Complex tests fail for 'mips64el'.")

to skip the few tests seen as failing.

Describe alternatives you've considered

We could keep the patch local to the Debian packaging but that is not a good long-term approach.

Additional context

N/A

@eddelbuettel eddelbuettel added the enhancement New feature or request label Aug 26, 2023
@lgautier
Copy link
Member

I am happy to review and merge a PR in that sense. My first thought if is that I'd prefer pytest.mark.xfail to pytest.mark.skipif.

@eddelbuettel
Copy link
Author

Good to know -- 'skipif' was what the not-so-deep-into-Python-person that I am found first. But I have now heard from a Debian porter so maybe we will even get it addressed at the source.

For eyeballing the patch is here (and has at the very end the other little bit of silencing the timezone test we saw fail earlier):
https://sources.debian.org/src/rpy2/3.5.13-5/debian/patches/skip_complex_tests_on_mips64el/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants