Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Post Request doesnt set header "Upload-Concat": "partial" when parallel is >1 #685

Closed
mariusschroeterCP opened this issue Apr 3, 2024 · 3 comments
Assignees
Labels
bug Something isn't working in-progress no-stale

Comments

@mariusschroeterCP
Copy link

We are using an implementation of the tusdotnet package as our tus server.

When uploading a new video file from the client with react-uploady with following settings:

<TusUploady
      key={authCtx.authUser?.userId}
      autoUpload={false}
      multiple={false}
      accept="video/*"
      enhancer={enhancer}
      forgetOnSuccess={true}
      chunkSize={8_000_000}
      parallel={4}
/>

We saw a difference from the package "https://github.com/tus/tus-js-client", which we are using on a different project:

Tus-JS-Client Headers

tus-js-client-parallel-upload

Uploady

tus-uploady-parallel-upload

Expected Behavior
The POST requests should have the correct "Upload-Concat" Header ("partial", and "final" for the summarized file).

Versions
"@rpldy/mock-sender": "^1.8.0",
"@rpldy/retry-hooks": "^1.8.0",
"@rpldy/tus-uploady": "^1.8.0",
"@rpldy/upload-button": "^1.8.0",
"@rpldy/upload-drop-zone": "^1.8.0",
"@rpldy/upload-preview": "^1.8.0",
"@rpldy/uploady": "^1.8.0",

@yoavniran yoavniran self-assigned this Apr 5, 2024
@yoavniran
Copy link
Collaborator

hi @mariusschroeterCP
I will look into this and let you know

@yoavniran
Copy link
Collaborator

Hi @mariusschroeterCP
Finally found time to have a look. It does indeed seem to be an oversight on my part.
Will have an RC version for you to check soon.

@yoavniran
Copy link
Collaborator

fix (finally) released - https://github.com/rpldy/react-uploady/releases/tag/v1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-progress no-stale
Projects
None yet
Development

No branches or pull requests

2 participants