Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signature::Signer support #286

Open
baloo opened this issue Feb 12, 2024 · 6 comments
Open

signature::Signer support #286

baloo opened this issue Feb 12, 2024 · 6 comments

Comments

@baloo
Copy link

baloo commented Feb 12, 2024

Hi!

I was wondering if maybe you'd be open to have support for signature::Signer in the crate.
This would allow to separate the storage of a private key on a hardware token instead.

This is not a request for anyone to work on it, more a question to know whether such work could get merged eventually.

Thanks!

@dignifiedquire
Copy link
Member

Generally I think it would be nice to support it, though I am curious how you see this working?

@baloo
Copy link
Author

baloo commented Feb 12, 2024

I'm not too sure yet. I wanted to ask before investing a significant amount of time in it.

I think moving a couple API towards generic (binding to the SecretKeyTrait) and creating an implementation of impl SecretKeyTrait for T where T: signature::Signer should do?
There might be more than that.

@dignifiedquire
Copy link
Member

the issue is that a lot of the internals are enum bound, especially on the parsing side, so might run into issues there

@wiktor-k
Copy link
Contributor

I think it's a great idea to keep in mind. I'm also interested in rpgp supporting various hardware tokens and utilizing common Rust traits would definitely make it easier. 👍

@baloo
Copy link
Author

baloo commented Feb 20, 2024

@wiktor-k nice to see you here too haha!

@wiktor-k
Copy link
Contributor

@wiktor-k nice to see you here too haha!

Ha, yeah 👋 I remember you from the cryptoki repo which I also maintain... apparently we're interested in roughly the same stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants