Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an example application to grpc-kotlin #26

Open
leveretka opened this issue Nov 20, 2018 · 3 comments
Open

Adding an example application to grpc-kotlin #26

leveretka opened this issue Nov 20, 2018 · 3 comments

Comments

@leveretka
Copy link

Hi!

I created a new app for grpc kotlin talk at Devoxx UA. Here it is https://github.com/leveretka/grpc-death-star

I would really appreciate if you can leave some comments and review the usage of your lib there.

One more thing is we can add this project to your repo as an example of grpc-kotlin usage. Wdyt?

P.S. Unfortunately have no other channel of communication with, only opening issues in github. So would be great if you provide me with some other contacts

@rouzwawi
Copy link
Owner

Hi, I will take a look and leave some feedback! 🌟

As for communication channels, I recently created a channel on Gitter: https://gitter.im/gRPC-Kotlin/Lobby. Just me there right now but gotta start somewhere :)

@rouzwawi
Copy link
Owner

rouzwawi commented Nov 20, 2018

Here's some suggested things that I think could make the project easier to navigate and work with.

  • Drop uses of GlobalScope and just use launch directly in service code since they implement CoroutineScope (PR sent)
  • Set up multi-module Gradle build so the whole system can be built in one go. I had to copy the -api jar into the other directories manually, and also needed to import each submodule individually into IntelliJ
  • Build Docker images as part of Gradle build
  • Use Docker Compose for running locally
  • Use Gradle Kotlin DSL?

@leveretka
Copy link
Author

Cool! Thank you for your feedback. Merged your PR. Will update the project regarding your comments. I also want to add unit, it and e2e tests. Not sure will do it before Devoxx (it's this Friday and Saturday). But will do it afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants