-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Electron App #64
Comments
Questions
Possible solutionIn order to support this we would need to re-write or make some changes to the underlying code because right now we are using python with Flask to serve as our backend and do Server-Side Rendering(jinja2 template injections) and electron is a NodeJS based application. This can be done if we separate Frontend(FE) and Backend we can make use of a FE framework like react,vue or angular for client side rendering and switch to a REST API model which can support this. |
@M-Faheem-Khan These are great questions.
I will say, perhaps I should be more specific. I am not looking to rewrite the code or anything. There are many Electron apps out there that are just a containerized version of a website. It just loads the website. I think I've created a way to do this with GitHub actions. So I can assign this to myself. But I'd much rather have any real dev work go towards adding features like multi-file upload or some other ideas. But, as I said in Answer 1. There is nothing this brings other than a change in workflow. Perhaps it is just for me. But given that it won't take anything more than adding something to the GitHub pipeline, I think it might be worth a try. But no. Let's not change everything just because. Not yet, at least. Thoughts? |
I see, we can easily add this to our pipeline and shouldn't take up much work and or change to the underlying code. I'll take up #38. |
@M-Faheem-Khan can you comment on that issue so I can assign it to you? Thanks. |
I was looking at several Electron Wrappers and thought it would be cool to generate an Electron app for this project. It would work the same as the web version but would provide packages for Linux, Windows, and Mac.
I thought we could implement something like this project: https://github.com/samuelmeuli/action-electron-builder
Or if we could convert this project to a GitHub action for deployment: https://github.com/nativefier/nativefier
The text was updated successfully, but these errors were encountered: