Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic update of analysis page #169

Open
aditirao7 opened this issue Oct 3, 2023 · 8 comments
Open

Dynamic update of analysis page #169

aditirao7 opened this issue Oct 3, 2023 · 8 comments

Comments

@aditirao7
Copy link
Collaborator

It seems like the analysis page lost the functionality of updating dynamically as and when the link results are available? I'm pretty sure that it used to update dynamically before. Is this the desired behaviour @marshalmiller ?

@marshalmiller
Copy link
Collaborator

@aditirao7 Was this in the version from last week? Or has this been for a bit? I still believe the functionality is there. The issue is that we are now using a broker to accomplish tasks. The tasks are sent off to Celery and returned when finished. Without this, many runs were timing out, and there was little ability to run multiple sessions simultaneously. So, we went to the broker method. It has sped up a bit, but this dynamic updating might have been a casualty. If this is new to this week, I can go back and see where a conflict might have occurred.

@aditirao7
Copy link
Collaborator Author

@marshalmiller I'm not sure about the timeline of the change but ever since I started contributing again it was already like this. Currently it seems like it waits for all the celery tasks to finish and then shows the final results?

@marshalmiller
Copy link
Collaborator

Yes. I believe that is correct. I would love for that not to be the case, but I'm not sure of a way to accomplish both.

@marshalmiller
Copy link
Collaborator

@aditirao7 I appears like since you made your design changes for the PDF, the site does not return anything. I can look through the celery logs and everything is fine there. So it is an issue with the analysis page and you're the only one I can see has made changes to that recently. Any Ideas what is going on?

@aditirao7
Copy link
Collaborator Author

aditirao7 commented Oct 13, 2023

@marshalmiller It was working fine on local up till my changes, after pulling the new changes it stopped working. Also looks like my changes for the new pdf report format also got reverted and the analysis page design is also a mess 😿

@aditirao7
Copy link
Collaborator Author

aditirao7 commented Oct 13, 2023

UPDATE: Reverted to my latest commit and it worked perfectly, after that I added the next commit and it stopped working. The change is breaking analysis because of a syntax error. Will submit a pull request to fix it.

@aditirao7 aditirao7 mentioned this issue Oct 13, 2023
@marshalmiller
Copy link
Collaborator

@aditirao7 I'm sorry if I messed it up. Thank you for resolving it all, though. I really appreciate it. The design is just changing. Final touches should be good soon. Idk why the PDF report was touched though. I can look into that.

@aditirao7
Copy link
Collaborator Author

@marshalmiller No worries! Yep the PDF report part was removed maybe because of rebasing issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants