New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
okx frozen balance add #7922
okx frozen balance add #7922
Conversation
Remove PNPM_VERSION and NODE_VERSION from ci configuration
Thanks! Make sure to run the linter with |
Co-authored-by: Yábir Benchakhtir <yabirgb@gmail.com>
Also please limit the PR to one commit (you can squash them) and add a changelog entry. Also target |
I think it is okay now can you check again? |
@izzetemredemir by changing the branch target only you are bringing commits from develop. You would need to pick only your changes in a branch based on bugfixes. The changes look okey but as I said limit it to a commit. ANd add a changelog entry to docs/changelog.rst |
Can you check changelog update? After that I am going to squash commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the PR but you need to rebase your commits on top of bugfixes and not put all of develop with it like you did now.
Do not squash develop commits into yours as this will also not be accepted.
Just don't pull any un-needed commit into develop.
Finally please sign the CLA.
Thank you!
Co-authored-by: Lefteris Karapetsas <lefteris@refu.co>
Co-authored-by: Lefteris Karapetsas <lefteris@refu.co>
hey @izzetemredemir this is still pulling develop into bugfixes. If you don't know how to fix this just let me know and I can take over the PR and fix it for you. |
I have created a new pull request as a more practical method to resolve the Git errors. Please consider closing this one and reviewing the new one: Thank you. |
Closes #7915
I've fixed an issue where frozen balances were not displaying on OKX TR. After implementing the correction, I tested the changes and confirmed that everything is now working correctly.
Please review the changes at your convenience.