Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support coinbase developer portal API keys #7815

Closed
m-roberts opened this issue Apr 24, 2024 · 10 comments
Closed

Support coinbase developer portal API keys #7815

m-roberts opened this issue Apr 24, 2024 · 10 comments
Milestone

Comments

@m-roberts
Copy link

m-roberts commented Apr 24, 2024

Problem Definition

I am unable to connect to Coinbase as I have no legacy keys that I can use, nor can I create any.

When I create an API key via Coinbase Development Platform portal (which seems to be the only way to do this now), I get key and secret that don't work with rotki.

According to the Coinbase docs, a JWT needs to be generated and from a glance at the code, this isn't what is done currently - it seems like the rotki implementation only supports signing in with Coinbase's legacy keys.

System Description

Operating system: macOS
Rotki version: v1.32.2

@m-roberts m-roberts changed the title Can't connect to Coinbase (Coinbase Development Platform (CDP) API keys don't work) Can't connect to Coinbase with newly created Coinbase API keys Apr 24, 2024
@m-roberts m-roberts changed the title Can't connect to Coinbase with newly created Coinbase API keys Can't connect to Coinbase with non-legacy Coinbase API keys Apr 24, 2024
@LefterisJP
Copy link
Member

Hey @m-roberts ,you can create a coinbase api key via https://www.coinbase.com/settings/api. It's still possible as per the docs you linked.

If you have trouble with this please contact coinbase support. I just went to my coinbase, generated keys and input them succesfully into rotki.

Supporting this new method, is something we may need to think of, but not really urgent as the other method is still supported.
I will keep the issue open so we can support this new "CDP", Coinbase Developer Portal API keys.

Seems like a step backwards from the user experience to me, asking a simple user to go to a developer portal, instead of doing it from inside the exchange.

@LefterisJP LefterisJP changed the title Can't connect to Coinbase with non-legacy Coinbase API keys Support coinbase developer portal API keys Apr 24, 2024
@m-roberts
Copy link
Author

m-roberts commented Apr 24, 2024

The legacy method is not available for me - I only have Create & Manage API Keys with Coinbase Developer Platform and New OAuth2 Application (see screenshot below).

Legacy tokens that have already been created will continue to work for now, but new ones do not appear to be able to be created.

Screenshot 2024-04-25 at 00 03 06

@LefterisJP LefterisJP added this to the 1.33.0 milestone Apr 24, 2024
@LefterisJP
Copy link
Member

Thanks for the response and the info @m-roberts! We will see what we can do to speed this up.

Still contact support of coinbase maybe they can help. This is on them. i have two accounts with them and both allow me to still create normal api keys. So maybe there is something they can switch for your account to make it appear?

It makes sense too, as most apps, us included have those integrated. Can't just cut off so many different apps for their users by cutting off the api keys we know so far.

@m-roberts
Copy link
Author

Will do! Hopefully it's an account configuration issue that can be documented once it's better understood.

@m-roberts
Copy link
Author

m-roberts commented Apr 25, 2024

I was unable to get anywhere with their support staff, and so have simply opted to cash out and use another exchange.

@scottshapiro
Copy link

Coinbase product team here. Looking into this.

@bjeavons-cb
Copy link

@m-roberts Some of our Coinbase Eng team is working to address these issues, will you contact me on email too? benjamin.jeavons@coinbase.com

Here's what we're doing

  1. Bringing back creation of the old API keys, temporarily
  2. Authoring the PR in rotki to also support new API keys
  3. Publishing and promoting a guide for other apps and developers on how to upgrade their integration to use CDP API keys too

@bjeavons-cb
Copy link

@m-roberts legacy API keys can be created again now on coinbase.com/settings/api

@bjeavons-cb
Copy link

PR to add CDP key support: #7902

@yabirgb yabirgb modified the milestones: 1.33.0, 1.33.1 May 8, 2024
@LefterisJP
Copy link
Member

Should be addressed by #7903 and will be in 1.33.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants