Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH staking EL block/mev rewards do not limit them to tracked fee recipient #7784

Open
LefterisJP opened this issue Apr 19, 2024 · 0 comments

Comments

@LefterisJP
Copy link
Member

LefterisJP commented Apr 19, 2024

Abstract

Fren @Buttaa reported this.

2024-04-19_14-44

At the moment if the fee recipient for a validator's block/mev (EL rewards) is not tracked by rotki, then the reward won't be counted. It seems our current logic has it as a requirement to track the fee recipient.

There is some setups like having a staking service that needs fee reipient be a common address where this won't work. We need to account for them.

Specification

Count EL rewards for a validator if the validator is tracked. So if the validator finds a block and either the block reward or the MEV reward (need to think how to differentiate them) goes to a non-tracked fee recipient, still count them as earned EL rewards.

Open questions:

  1. Without a tracked fee recipient (and a list of builder adddresses) how would you differentiate between which of the mev reward or block reward or both to count as reward?
  2. At some other point that ETH is gonna be claimed by the user. Would it not be double counting them in the PnL report when it touches a tracked address?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant