Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cite/reflist enhancements #6

Open
2 of 3 tasks
rosslh opened this issue Jan 17, 2019 · 3 comments · Fixed by #80 · May be fixed by #81
Open
2 of 3 tasks

Cite/reflist enhancements #6

rosslh opened this issue Jan 17, 2019 · 3 comments · Fixed by #80 · May be fixed by #81
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rosslh
Copy link
Owner

rosslh commented Jan 17, 2019 •
edited

  • smooth scroll
  • highlight reflist item
  • tooltip on hover?
@rosslh rosslh added the enhancement New feature or request label Jan 17, 2019
@rosslh rosslh self-assigned this Jan 17, 2019
@rosslh rosslh added the good first issue Good for newcomers label Jan 17, 2019
@rosslh rosslh removed their assignment Jan 17, 2019
@eostrom
Copy link
Contributor

eostrom commented Oct 2, 2019

Hi! Would you be open to a PR for this? I added smooth scroll to https://climatechoice.co (also a React app, by way of Gatsby), and I'd like to try adding that and the other two things here as well.

@eostrom eostrom mentioned this issue Oct 2, 2019
Merged
@rosslh
Copy link
Owner Author

rosslh commented Oct 3, 2019

Hi @eostrom, yes a PR for this would be appreciated!

This was referenced Oct 19, 2019
Merged
Open
eostrom added a commit to eostrom/IsEarthStillWarming.com that referenced this issue Oct 20, 2019
@eostrom
Enabled smooth scrolling (rosslh#6).
0dd2902 
For browsers that support it.

There's a [polyfill](https://github.com/wessberg/scroll-behavior-polyfill)
but I'm not sure this is important enough to complicate the code for.
We can just wait for Safari and Edge to catch up.
@eostrom eostrom mentioned this issue Oct 20, 2019
Open
eostrom added a commit to eostrom/IsEarthStillWarming.com that referenced this issue Oct 22, 2019
@eostrom
Enabled smooth scrolling (rosslh#6).
9e729fc 
For browsers that support it.

There's a [polyfill](https://github.com/wessberg/scroll-behavior-polyfill)
but I'm not sure this is important enough to complicate the code for.
We can just wait for Safari and Edge to catch up.
@eostrom eostrom mentioned this issue Oct 22, 2019
Merged
rosslh pushed a commit that referenced this issue Oct 23, 2019
@eostrom @rosslh
Enabled smooth scrolling (#6).
533f281 
For browsers that support it.

There's a [polyfill](https://github.com/wessberg/scroll-behavior-polyfill)
but I'm not sure this is important enough to complicate the code for.
We can just wait for Safari and Edge to catch up.
@rosslh rosslh reopened this Oct 23, 2019
@eostrom
Copy link
Contributor

eostrom commented Oct 23, 2019

FWIW I played around with tooltips and never found a solution I loved. Some obstacles:

  • npm modules that were big and drew in dependencies
  • npm modules that didn't support HTML (for links)
  • npm modules that did, but only as strings, and I, new to React, didn't know how to render the citation safely as a string
  • (specifically, the citations all have links inside <angle brackets>, which need to be escaped)
  • even if everything works, some of the citations are just a lot of text for a tooltip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@eostrom @rosslh