Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Webpage Crash with Long QR Code Data Inputs #255

Open
sabeerbikba opened this issue Mar 23, 2024 · 0 comments
Open

Fix for Webpage Crash with Long QR Code Data Inputs #255

sabeerbikba opened this issue Mar 23, 2024 · 0 comments

Comments

@sabeerbikba
Copy link

Issue Summary:

The current implementation of the react-qr-code library encounters a crash when attempting to generate a QR code with a data input exceeding approximately 2953 characters. This limitation significantly impacts the usability of the library for applications requiring the generation of QR codes with larger data sets.

Problem Description:

When a user attempts to generate a QR code with a data input exceeding 2953 characters, the webpage crashes, and errors are displayed in the console. This issue has been identified and reported by users of our application, leading to a need for a fix.

Impact:

This limitation restricts the library's utility in scenarios where QR codes need to encode larger amounts of data, such as in inventory management systems, detailed product descriptions, or complex URLs. The crash not only disrupts the user experience but also poses a significant barrier to the library's adoption in applications requiring the generation of QR codes with extensive data.

Proposed Solution:

We propose implementing a solution that allows the library to handle data inputs of any length without causing the webpage to crash. This could involve optimizing the data encoding process or implementing a mechanism to gracefully handle large inputs, such as splitting the data into multiple QR codes or compressing the data before encoding.

Related Issue:

This issue is related to a pull request (PR) we submitted to address a similar problem by setting a limit of 1500 characters for QR code data inputs in our application. The PR aims to mitigate the issue by preventing the generation of QR codes with excessively long data inputs, which was causing crashes. However, this workaround does not address the root cause of the problem and does not provide a complete solution for users needing to encode larger data sets.

Request:

We kindly request the maintainers of the react-qr-code library to consider this issue and provide a fix that allows for the generation of QR codes with data inputs of any length. This will significantly enhance the library's usability and applicability across a wider range of applications.

Additional Information:

GitHub Issue Link: [https://github.com/YourAverageTechBro/DevToolboxWeb/issues/54]
Request Link: [https://github.com/YourAverageTechBro/DevToolboxWeb/pull/60]

Screenshots:

qrcode-error

We look forward to a resolution that improves the robustness and flexibility of the react-qr-code library, enabling it to serve a broader range of use cases effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant