Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Soft-)deprecate column_map()? #284

Open
jmobrien opened this issue Sep 7, 2022 · 2 comments
Open

(Soft-)deprecate column_map()? #284

jmobrien opened this issue Sep 7, 2022 · 2 comments

Comments

@jmobrien
Copy link
Collaborator

jmobrien commented Sep 7, 2022

column_map() uses the old endpoint (e.g. #267), sometimes creates issues (e.g. #283), and has an established replacement (extract_colmap()). Should we go ahead and deprecate it?

If so, should we soft-deprecate w/a warning pointing to the new function, or go ahead and deprecate fully (throwing a similarly-worded error)?

Leaning towards the latter since I think the older version really doesn't offer anything uniquely useful, so most all users probably want the newer maps.

@juliasilge
Copy link
Collaborator

Yeah, let's go straight to deprecate_warn() with this. Good idea.

@jmobrien
Copy link
Collaborator Author

jmobrien commented Sep 7, 2022

Okay, I was using the language inadequately here, but thanks for the link. deprecate_warn() makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants