Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in fingertips_data() if specifying pulling multiple indicators with ProfileID and rank = TRUE #112

Open
oloverm opened this issue Feb 1, 2023 · 1 comment

Comments

@oloverm
Copy link

oloverm commented Feb 1, 2023

If you specify a ProfileID and rank = TRUE while trying to pull multiple indicators, it gives an error:

fingertipsR::fingertips_data(c(92254, 91819),
                             ProfileID = c(45, 45),
                             AreaTypeID = 402,
                             ParentAreaTypeID = 104,
                             rank = TRUE)
#> Error in parse_url(url) : length(url) == 1 is not TRUE

For reference, these options all work fine

# No rank
fingertipsR::fingertips_data(c(92254, 91819),
                             ProfileID = c(45, 45),
                             AreaTypeID = 402,
                             ParentAreaTypeID = 104)

# No profile
fingertipsR::fingertips_data(c(92254, 91819),
                             AreaTypeID = 402,
                             ParentAreaTypeID = 104,
                             rank = TRUE)

# One indicator
fingertipsR::fingertips_data(92254,
                             ProfileID = 45,
                             AreaTypeID = 402,
                             ParentAreaTypeID = 104,
                             rank = TRUE)

This is with version 1.0.9

@sebastian-fox
Copy link
Member

hi @oloverm - sorry for the delay in responding. Thanks for reporting this.

I've just pushed an update that should sort this (b9dc195). It takes a while to get onto the rOpenSci repository, so if you want to test it in the next couple of days, you'll need to use

remotes::install_github("ropensci/fingertipsR")

If you're happy with the change, then please could you close this issue.
Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants