Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The message of what data sets are found could be improved. #51

Closed
gfinak opened this issue Sep 6, 2018 · 1 comment
Closed

The message of what data sets are found could be improved. #51

gfinak opened this issue Sep 6, 2018 · 1 comment

Comments

@gfinak
Copy link
Member

gfinak commented Sep 6, 2018

The message:

1 required data objects created by ....
is echoed after rendering each script.

This is lost amongst the output of the build process.
It could be improved by:

  • being more specific.
    • What data object was found.
    • How many are expected in all.
    • What file was just processed.
    • Cleaner output using usethis::done().

Related to #50
gfinak added a commit that referenced this issue Sep 7, 2018
@gfinak
Tidy up the output of which data sets were created.
20c6a14 
Set default package_build to install = FALSE.
#51
gfinak added a commit that referenced this issue Sep 7, 2018
@gfinak
Improve logging.
a0f74d0 
Improve console messages.
#50 and #51
@gfinak
Copy link
Member Author

gfinak commented Sep 12, 2018

Output now looks as follows:

image

  • more informative message tells us what data set was built in what file and how many more are expected.

@gfinak gfinak closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gfinak