Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up package build NOTEs #93

Open
roninsightrx opened this issue May 9, 2023 · 0 comments
Open

Clean up package build NOTEs #93

roninsightrx opened this issue May 9, 2023 · 0 comments

Comments

@roninsightrx
Copy link
Collaborator

NOTEs below should be avoided.

❯ checking top-level files ... NOTE
  Non-standard file/directory found at top level:
    ‘docs’

❯ checking dependencies in R code ... NOTE
  Unexported object imported by a ':::' call: ‘ggplot2:::label_variable’
    See the note in ?`:::` about the use of this operator.

❯ checking R code for possible problems ... NOTE
  Found if() conditions comparing class() to string:
  File ‘vpc/R/add_stratification.R’: if (class(dat$strat) != "factor") ...
  File ‘vpc/R/binning.R’: if (class(n_bins) != "numeric" | is.null(n_bins)) ...
  File ‘vpc/R/define_bins.R’: if (class(bins) != "numeric") ...
  File ‘vpc/R/define_bins.R’: if (!is.null(kmmc) & (class(bins) == "logical" && bins == FALSE)) ...
  File ‘vpc/R/define_bins.R’: if (!(class(bins) == "logical" && bins == FALSE)) ...
  File ‘vpc/R/define_bins.R’: if (class(bins) == "logical" && bins == TRUE) ...
  File ‘vpc/R/define_bins.R’: if (class(bins) == "character") ...
  File ‘vpc/R/define_bins.R’: if (class(bins) == "numeric") ...
  File ‘vpc/R/plot_vpc.R’: if (is.null(vpc_theme) || (class(vpc_theme) != "vpc_theme")) ...
  File ‘vpc/R/plot_vpc.R’: if (!(class(bins) == "logical" && bins == FALSE)) ...
  Use inherits() (or maybe is()) instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant