Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests #9

Open
dpastoor opened this issue Oct 24, 2014 · 3 comments
Open

tests #9

dpastoor opened this issue Oct 24, 2014 · 3 comments

Comments

@dpastoor
Copy link
Collaborator

I see this package suited two test 'suites' - unit tests for the functions and processes and a visual check to make sure we're getting the output we expect.

Unit tests can be added incrementally, but for the visual tests we could use some existing datasets and use xpose or 'manually' check that they are correct, save the output as images then whenever we make substantial changes we can run the new code and make sure we can generate the plots so they look the same. It shouldn't be too difficult to have an Rmarkdown document almost like a vignette that would display the plots side-by-side for comparison.

@ronkeizer
Copy link
Owner

OK

@billdenney
Copy link
Contributor

@devinpastoor, do you know of a good way to automate visual tests? I just made a PR switching to testthat, so I hope that it would be simpler to integrate more tests.

@billdenney
Copy link
Contributor

And, as a follow-up to my own comment, it looks like vdiffr (https://github.com/r-lib/vdiffr) is used by ggplot2, so it should be good enough for us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants