Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more robust filter_dv testing and thought #24

Open
dpastoor opened this issue Jan 28, 2015 · 1 comment
Open

add more robust filter_dv testing and thought #24

dpastoor opened this issue Jan 28, 2015 · 1 comment

Comments

@dpastoor
Copy link
Collaborator

need to determine if the current method (returning x if class not recognized) is viable or should make a data.frame generic and then throw error for rest (eg do we want this to proceed silently if someone passes in a matrix or otherwise?

filter_dv also needs generic testing for non-classed passed through (eg passing data frame)

@ronkeizer
Copy link
Owner

sure, adding more tests is fine. 'matrix' class can be converted into data.frame, we can throw a warning that they should not pass matrices, but should proceed anyhow.

feel free to improve on my updates of the filter_dv() function, I just needed this fixed quickly for a colleague that needed a vpc a.s.a.p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants