Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting EF.Functions.Like and/or prossibility to provide cusotm ExpressionVisitor #73

Open
InspiringCode opened this issue Jan 24, 2024 · 1 comment

Comments

@InspiringCode
Copy link

Is there any chance that you can support the most common EF functions like EF.Functions.Like?

An relatively simple approach might be to write an ExpressionVisitor that replace those function calls with mock functions.

I think it would generally be a great idea to add an optional Visitor property to TestAsyncEnumerableEfCore<T> where you can pass a custom visitor that is used instead of the new TestExpressionVisitor(). This would allow developers to mock all sorts of custom functions and the like.

I would really appreciate this feature.

@romantitov
Copy link
Owner

Hello @InspiringCode I also think this is indeed a great idea to implement functionality to support EF.Functions.Like, but unfortunately I will not have enough time to implement it. Feel free to provide a pull request with the infrastructure and I would be happy to include it to the next release. Please don't forget to cover the case by additional tests to minimize possibility of regressions for the future. Thanks for the understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants