Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer UI defects on Redoc sidebar #274

Open
jrub opened this issue Feb 28, 2023 · 9 comments
Open

Footer UI defects on Redoc sidebar #274

jrub opened this issue Feb 28, 2023 · 9 comments
Labels
bug Something isn't working help wanted PRs are encouraged and will be accepted styles

Comments

@jrub
Copy link
Contributor

jrub commented Feb 28, 2023

Hi there, I built the Redoc component as the main page and the footer is showing some glitches as the Redocly watermark shows above it. I'm using the default themes. Any ideas or tips to improve it? Thx

image

@rohit-gohri rohit-gohri added bug Something isn't working styles labels Feb 28, 2023
@rohit-gohri
Copy link
Owner

Can recreate this on the example website - https://redocusaurus.vercel.app/docs/nested/nested-1#tag/store_model
image

@jrub
Copy link
Contributor Author

jrub commented Feb 28, 2023

Also note that depending on the screen size, when using three colums they stack too soon

Screenshot_2023-02-28-14-15-05-818_com.duckduckgo.mobile.android.jpg

@rohit-gohri
Copy link
Owner

Any ideas or tips to improve it?

I don't really have a fix for this. You might have to fix this with some custom css like the custom fixes already added here - https://github.com/rohit-gohri/redocusaurus/blob/main/packages/docusaurus-theme-redoc/src/theme/Redoc/styles.css

Would be happy to merge and release a PR.

Also note that depending on the screen size, when using three colums they stack too soon

That is just default docusaurus theme, nothing to do with redoc.

@rohit-gohri rohit-gohri added the help wanted PRs are encouraged and will be accepted label Feb 28, 2023
@Innders
Copy link

Innders commented Mar 24, 2023

If you are looking for a quick fix. Then you can add this css to your custom.css file.

.menu-content .scrollbar-container > ul + div {
    position: relative;
}

@jrub
Copy link
Contributor Author

jrub commented Mar 27, 2023

Thanks @Innders , however I don't see any .menu-content or .scrollbar-container on my code? 🤔

@Innders
Copy link

Innders commented Mar 27, 2023

@jrub you need to add that whole code snippet above to the default custom.css file that's created when you initialised docusaurus.

image

@jrub
Copy link
Contributor Author

jrub commented Mar 27, 2023

@Innders well I recreated the file as I removed it at some point, but it did not work. I had this when I initialised: jrub/redocusaurus_test@ee18599#diff-44813f307e729042af7e70beff6f32ea63a7941bc100043a49e84d229ea2570f so I think it might be a different thing form what you're getting? (as again, those classes are not around). Thanks again!

@Innders
Copy link

Innders commented Mar 27, 2023

@jrub make sure you uncomment this line in your docusaurus.config.js file. Otherwise the CSS file won't be included in your build and none of those styles will be applied.

I just tried it in your repo and it worked for me :)

image

@jrub
Copy link
Contributor Author

jrub commented Mar 27, 2023

yeah, I did, plus relaunching yarn start, just in case 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted PRs are encouraged and will be accepted styles
Projects
None yet
Development

No branches or pull requests

3 participants