Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling issue with callbacks in dark mode #156

Open
becca-tiessen opened this issue Mar 22, 2022 · 2 comments
Open

Styling issue with callbacks in dark mode #156

becca-tiessen opened this issue Mar 22, 2022 · 2 comments
Labels
bug Something isn't working help wanted PRs are encouraged and will be accepted styles

Comments

@becca-tiessen
Copy link

My team has noticed that the styling for callbacks in dark mode is virtually unreadable, and it looks like this is also the case on the example docs.
If this is a known issue are there any suggested workarounds?
Thanks!

Light mode:
Screen Shot 2022-03-22 at 4 09 10 PM

Dark mode:
Screen Shot 2022-03-22 at 4 08 56 PM

@rohit-gohri rohit-gohri added bug Something isn't working styles labels Mar 23, 2022
@rohit-gohri
Copy link
Owner

Thanks for pointing it out. I haven't used callbacks so didn't notice them.

I think the fix would just be fixing the styling here:

.redocusaurus table tr {
background-color: var(--ifm-background-color);
}
.redocusaurus table > tbody > tr {
color: var(--ifm-font-color-base);
}
.redocusaurus table tbody tr table {
background-color: var(--ifm-background-surface-color);
}
.redocusaurus table tbody tr table tbody tr {
background-color: var(--ifm-background-surface-color);
}
.redocusaurus tr.last + tr > td > div {
background-color: var(--ifm-background-color) !important;
}

We would probably need to apply different styles for callbacks. If you want to give it a try, PRs are most welcome

@rohit-gohri rohit-gohri added the help wanted PRs are encouraged and will be accepted label Mar 23, 2022
@a00012025
Copy link

Hi, is there any suggestion on how to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted PRs are encouraged and will be accepted styles
Projects
None yet
Development

No branches or pull requests

3 participants