Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFL Boxscore initialization failing #724

Open
cvalentino opened this issue May 15, 2022 · 2 comments · May be fixed by #725
Open

NFL Boxscore initialization failing #724

cvalentino opened this issue May 15, 2022 · 2 comments · May be fixed by #725

Comments

@cvalentino
Copy link

code to repeat issue:
boxscore = Boxscore("202109090tam")

Seeing an error originating from line 784 in nfl/boxscore.py
value = self._parse_name(short_field, boxscore)

pyquery ParserError: Document is empty

Full stack trace should be easy to get by running that first line of code. Let me know if you need any more information to describe the issue.
@david-jackson23
Copy link

Hello, this is my first time really working with API's. I understand the issue and have looked at the .py file. I'm not following on how to fix the issue though. Can you clarify it for me please?

@dwalton76 dwalton76 linked a pull request May 17, 2022 that will close this issue
Open
@greent12
Copy link

I know this was addressed in #725, and it looks like the pull request was accepted. However, the changes in e2aabf3 do not seem to be reflected in the master branch yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NFL: correct home_name and away_name BOXSCORE_SCHEME dwalton76/sportsipy
3 participants
@greent12 @cvalentino @david-jackson23