Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBA rosters not being pulled correctly #722

Open
Jack-Gitter opened this issue Apr 7, 2022 · 0 comments
Open

NBA rosters not being pulled correctly #722

Jack-Gitter opened this issue Apr 7, 2022 · 0 comments

Comments

@Jack-Gitter
Copy link

Describe the bug
The NBA rosters are not being pulled correctly

To Reproduce
Sample code which causes an issue.

from sportsipy.nba.teams import Teams
]
def findThreePointShooters(event=None,context=None):

    teams = Teams()
    for team in teams:
        roster = team.roster
        print(roster)

Expected behavior
To print all of the rosters in the NBA

Fix
A github post mentions changing this:

teams_list = utils._get_stats_table(doc, 'div#all_team-stats-base')
opp_teams_list = utils._get_stats_table(doc, 'div#all_opponent-stats-base')

to this:

teams_list = utils._get_stats_table(doc, '#totals-team')
opp_teams_list = utils._get_stats_table(doc, '#totals-opponent')

in nba_utils.py

can this be fixed??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant