Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for reading/writing multiple audio formats #704

Open
gavv opened this issue Feb 20, 2024 · 2 comments
Open

Add test for reading/writing multiple audio formats #704

gavv opened this issue Feb 20, 2024 · 2 comments
Assignees
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet sound io Audio I/O tests

Comments

@gavv
Copy link
Member

gavv commented Feb 20, 2024

After merging #660, add a test to test_pump.cpp that is the same as write_read, but instead of checking only wav files, it should check all supported formats (mp3, aiff, etc).

The new test should:

  • invoke IBackend::discover_drivers()
  • find all file formats supported by backend (use DriverInfo::type to distinguish if given driver is a file format)
  • and perform the test for each of such formats

In other words, the test iterates over all backends, for each backend it iterates over all file formats, and for each such pair of backend+format it performs the same check as implemented in write_read test.

Doc: https://github.com/roc-streaming/roc-toolkit/blob/develop/docs/sphinx/internals/audio_backends.rst

@gavv gavv added tests help wanted An important and awaited task but we have no human resources for it yet easy hacks The solution is expected to be straightforward even if you are new to the project sound io Audio I/O labels Feb 20, 2024
@gavv gavv added this to Frontlog in kanban board Feb 20, 2024
@gavv gavv moved this from Frontlog to Help wanted in kanban board Feb 20, 2024
@emmhuber
Copy link

emmhuber commented Apr 1, 2024

Hello! I am new to the project and will be attempting to work on this issue.

@gavv
Copy link
Member Author

gavv commented Apr 10, 2024

@emmhuber You're welcome, #660 was merged recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet sound io Audio I/O tests
Projects
kanban board
Help wanted
Development

No branches or pull requests

2 participants