Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISink::flush() #703

Open
gavv opened this issue Feb 20, 2024 · 4 comments
Open

Add ISink::flush() #703

gavv opened this issue Feb 20, 2024 · 4 comments
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project enhancement help wanted An important and awaited task but we have no human resources for it yet sound io Audio I/O

Comments

@gavv
Copy link
Member

gavv commented Feb 20, 2024

Implement explicit flushing of buffered samples from sink to file.

  • add virtual void flush() = 0 to sndio::ISink
  • add this method to all ISink implementations
  • for most implementations, flush() should be no-op, as they don't use buffering
  • for SoxSink, flush() should send buffered samples to disk
  • sndio::Pump should invoke flush() when it exits from run()
@gavv gavv added enhancement help wanted An important and awaited task but we have no human resources for it yet easy hacks The solution is expected to be straightforward even if you are new to the project sound io Audio I/O labels Feb 20, 2024
@gavv gavv added this to Frontlog in kanban board Feb 20, 2024
@gavv gavv moved this from Frontlog to Help wanted in kanban board Feb 20, 2024
@HTH24
Copy link

HTH24 commented Mar 10, 2024

Hello gavv, I am really interested in this project as I have been podcasting for a couple of years.
One question as this might be my first open source contribution: I write C++ in Xcode, and I do not see any main.cpp file. How would I make amendments to the code? Run it on the terminal using git after I have made changes to all .cpp and .hpp files? Is this the preferred way?

@dmklepp
Copy link

dmklepp commented Apr 1, 2024

Hello, I'm new to this project. I will be attempting to fix this issue. Thank you!

@gavv
Copy link
Member Author

gavv commented Apr 10, 2024

Hello gavv, I am really interested in this project as I have been podcasting for a couple of years. One question as this might be my first open source contribution: I write C++ in Xcode, and I do not see any main.cpp file. How would I make amendments to the code? Run it on the terminal using git after I have made changes to all .cpp and .hpp files? Is this the preferred way?

@HTH24 Take a look at this page: https://roc-streaming.org/toolkit/docs/building/developer_cookbook.html

You need to use scons to build the project.

Hello, I'm new to this project. I will be attempting to fix this issue. Thank you!

@dmklepp Hi, thanks, I guess we should ask @HTH24 whether they still plan to work on this.

@HTH24
Copy link

HTH24 commented Apr 10, 2024

Thanks gave, I think I need more time to get familiar with the project. Let dmklepp take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project enhancement help wanted An important and awaited task but we have no human resources for it yet sound io Audio I/O
Projects
kanban board
Help wanted
Development

No branches or pull requests

3 participants