Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--title 'filename' does not work #1

Open
marade opened this issue Apr 4, 2023 · 8 comments
Open

--title 'filename' does not work #1

marade opened this issue Apr 4, 2023 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@marade
Copy link

marade commented Apr 4, 2023

SVGs and PNGs that are generated have "filename" in the center of the image.

@AndresICM
Copy link
Collaborator

Hello! try with simple quotation marks 'filename' instead of "filename"

@marade
Copy link
Author

marade commented Apr 4, 2023

Hi, thanks for the software! Unfortunately using 'filename' does not work and I get the same problem. If it helps, my GBFFs are generated using Bakta.

@AndresICM
Copy link
Collaborator

Hi! We'll look into that. We certainly didn't try with Bakta annotated genomes, so we might need to update genovi considering that.

@vsaona
Copy link
Collaborator

vsaona commented Apr 12, 2023

Hello. Are you using a directory as input or a single file?
"filename" feature only works when input is a directory, not a single file. This is because it only made sense for this case, since for a single file the name could be written directly, easily.

@marade
Copy link
Author

marade commented Apr 12, 2023

Yes, it's a directory.

@vsaona vsaona self-assigned this Apr 13, 2023
@marade
Copy link
Author

marade commented Apr 13, 2023

In my opinion the best way to handle this is to avoid the strange 'filename' scheme. argparse already has a better way:

parser.add_argument("-n", "--name", action="store_true", help="use the filename " +
"for title text.")

@vsaona
Copy link
Collaborator

vsaona commented Apr 17, 2023

¿Could you please send me the full command line you're trying? This is for me to test it and check in which cases it is not working.

@vsaona vsaona added the bug Something isn't working label Apr 17, 2023
@marade
Copy link
Author

marade commented May 8, 2023

genovi -i ../genovi -t 'filename' -s complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants