Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Kirby Toggles seem to be transformed from Booleans to strings – Keep Booleans #7

Open
Jones-S opened this issue Apr 9, 2020 · 3 comments
Open

Improvement: Kirby Toggles seem to be transformed from Booleans to strings – Keep Booleans #7

Jones-S opened this issue Apr 9, 2020 · 3 comments

Comments

@Jones-S
Copy link

Jones-S commented Apr 9, 2020 •
edited

Hi
It's me again.
This time with an improvement I'd want to suggest.

I am using a toggle in kirby and the default API would return something like this:
"inverted": true,

Whereas /rest returns "inverted": "1",.

I can work with it, but it would be nice if we actually kept the boolean values, wouldn't it?

Cheers

Jones
@robinscholz robinscholz added bug Something isn't working and removed bug Something isn't working labels Jul 7, 2020
@robinscholz
Copy link
Owner

Suspect this also has to do with smartypants parsing!

@Jones-S
Copy link
Author

Jones-S commented Jul 15, 2020

I see. Though I could not find anything in the docs, where it says that it transforms true to 1...

@robinscholz
Copy link
Owner

robinscholz commented Jul 15, 2020 •
edited

I'll take a closer look at this when I have the time, might not be related to smartypants. Will need to check what causes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jones-S @robinscholz