Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squares appear randomly with a custom font on Samsung devices. #89

Open
njovy opened this issue Mar 13, 2018 · 3 comments
Open

Squares appear randomly with a custom font on Samsung devices. #89

njovy opened this issue Mar 13, 2018 · 3 comments

Comments

@njovy
Copy link

njovy commented Mar 13, 2018

screenshot_20180314-033158_ticker example

Attached is a problematic screen with random squares on Samsung Galaxy S9.
This problem only happens on Samsung devices.

@naturalwarren
Copy link
Contributor

naturalwarren commented Mar 13, 2018

Did it reproduce on an emulator? This will be a fun one :)

I wonder if there's reports of this in Robinhood.

@njovy
Copy link
Author

njovy commented Mar 14, 2018

No it didn't happen on an emulator. I also tested on my Nexus 5X and a custom typeface was applied correctly. I think Samsung must have changed the way to display TextView.

public void setTypeface(Typeface typeface) {
         if(android.os.Build.MANUFACTURER.equals("samsung")){
            return;
        }
...

Above is a temporary fix for now to avoid this issue.

@jinatonic
Copy link
Contributor

🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants